feat: add new vibe triggers for hourly and disconnection notice#786
Draft
rojas-claudio wants to merge 8 commits intocoredevices:mainfrom
Draft
feat: add new vibe triggers for hourly and disconnection notice#786rojas-claudio wants to merge 8 commits intocoredevices:mainfrom
rojas-claudio wants to merge 8 commits intocoredevices:mainfrom
Conversation
Signed-off-by: Claudio Rojas <claudio@rojas.tech>
Signed-off-by: Claudio Rojas <claudio@rojas.tech>
…lients Signed-off-by: Claudio Rojas <claudio@rojas.tech>
…connect vibes Signed-off-by: Claudio Rojas <claudio@rojas.tech>
Signed-off-by: Claudio Rojas <claudio@rojas.tech>
Signed-off-by: Claudio Rojas <claudio@rojas.tech>
Signed-off-by: Claudio Rojas <claudio@rojas.tech>
Signed-off-by: Claudio Rojas <claudio@rojas.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two new vibration triggers to vibe score capable watches, one for the top of the hour and the other for a disconnect notice (both of which are already features in a number of community-made watchfaces, but never a system-wide feature).
For the time being, this will be left as a draft as I am seeking feedback, specifically in regards to triggering the vibe score(s) in
clock.canddebounced_connection_service.c. PebbleOS currently expects a system app (ResAppNum = 0) to be in focus when creating the vibe score, however, this will not work when the user is running a third-party app or watchface. At the moment, there is a workaround for this, but I am not sure if this is the cleanest or will be an accepted solution. Any pointers would be much appreciated :)Resolves issue #690.